Move usePostFields to wordpress/editor package
#67024
Merged
+74
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
oandregal
requested review from
youknowriad,
gigitux,
louwie17,
mcsf,
ellatrix and
ntsekouras
youknowriad
reviewed
Nov 15, 2024
| name: string; | ||
| } | ||
|
|
||
| function usePostFields(): UsePostFieldsReturn { |
There was a problem hiding this comment.
Instead of keeping the list of fields here, should we transform this to a "registration API" like actions and start opening the API in Gutenberg? Separate thing obviously, but just want to start this discussion.
There was a problem hiding this comment.
This is actually a relevant question for this PR: usePostActions is defined in the editor package; but I'm operating under the assumption that we want both to live in wordpress/fields at some point, that's why I'm moving it here. Is that your thinking as well?
After that, yeah, field registration would be nice. Probably private to Gutenberg for now?
There was a problem hiding this comment.
yeah usePostActions or more precisely for me getEntityActions selector lives in the editor package, mostly because creating new stores is not an easy task and also shouldn't be done at all for bundled packages. So temporarily, the store lives in the editor package. I think we should ultimately do the same for fields.
And when we decide to make things more public (make the fields package non bundled), we should probably move the store to the fields package.
There was a problem hiding this comment.
yeah usePostActions or more precisely for me getEntityActions selector lives in the editor package, mostly because creating new stores is not an easy task and also shouldn't be done at all for bundled packages. So temporarily, the store lives in the editor package. I think we should ultimately do the same for fields.
ok, so this means that, for now, we should move usePostFields to the editor package in preparation for adding extensibility. Later, when fields is public will move both to this package.
There was a problem hiding this comment.
That's a good plan. Do you think we should also add the postType as param here or in a follow up?
There was a problem hiding this comment.
Moved to editor at 1b76327
That's a good plan. Do you think we should also add the postType as param here or in a follow up?
It's best to do it when we add support for other post types.
There was a problem hiding this comment.
#67175 to pull the fields from the registry
youknowriad
reviewed
Nov 15, 2024
|
Size Change: -23 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Nov 15, 2024
|
Flaky tests detected in 1b76327. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11854674176
|
oandregal
changed the title
usePostFields to wordpress/fields packageusePostFields to wordpress/editor package
youknowriad
approved these changes
Nov 15, 2024
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #61084
What?
This PR finalizes moving the
usePostFieldshook fromedit-siteto thefieldspackage.Why?
This is the API we want to promote to consumers, they shouldn't have to work with fields individually.
How?
After having move all the fields individually (title, author, date, status, comment_status), this PR just moves the hook.
Testing Instructions
Smoke tests the Pages page, both dataviews and quickedit/dataform.